[MIRROR] It is now possible to survive the Mansus #203
+29
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24490
Original PR: tgstation/tgstation#79131
About The Pull Request
Fixes #79113
There were a handful of bugs with the Mansus realm, this PR fixes them.
Firstly an most importantly, a refactor to damage handling touched the "unholy determination" effect incorrectly (and I'm not even sure why?), causing it to damage you instead of healing you most of the time. This damage was not avoidable, so most people would be crit shortly after entering the area and stay there.
Secondly, some of the heretic realms were unlit. A change to when lazyloaded template atmosphere initialises means that the bonfires were trying to light themselves with no air. Now they do this in late_initialize instead, giving time for air to arrive.
Thirdly, the spooky hands were runtiming when passing through transit tiles outside of the bounds of the heretic map. They shouldn't be effected by shuttle drag anyway, so now they aren't.
Fourthly, I removed a row of empty space at the edge of the heretic map, just because it annoyed me slightly.
Finally, while I was touching the heretic buff I made it heal you 1/4 as much as it originally did. This is a balance change rather than a fix, I'll atomise it out if it is controversial but I don't really expect it to be.
In the future I would like to come back to these and make each realm more specific to the path, because I think we could make these both more exciting and more characterful.
Why It's Good For The Game
Once it is working properly, the hand dodging minigame is actually extremely forgiving, even if you don't move very much and get frequently hit. This means some of those hits might actually add some tension.
Changelog
🆑 Jacquerel
fix: You should be revived properly when entering the mansus realm following a heretic sacrifice
fix: The buff which is supposed to heal you in the mansus realm will now do that instead of unavoidably damaging you
balance: The mansus realm's healing buff heals for 25% as much as it did before it was broken
/:cl: